What does mean to support folder scope credentials?

redentialsProvider.lookupCredentials(
                StringCredentials.class,
                Jenkins.get(),
                ACL.SYSTEM,
                Collections.emptyList());

we have use this to get credentials from Jenkins plugin, they give us feed back that we have to support folder scope credentials

A user of Jenkins can define a folder and then an job in that folder. Or there can be a ComputedFolder, like a multibranch project that generates jobs for each branch in a version control system. If the user then adds credentials to the folder, those credentials should be available to the jobs that are in that same folder or in a child folder of it. This does not work with your code, which passes Jenkins.get() as the ItemGroup when it calls lookupCredentials. If you have a Run, you can call Run.getParent() to get a Job that you can then pass in as an Item to another overload of lookupCredentials. That way, lookupCredentials will be able to search for credentials in the correct folder.

This seems to be about Hosting request for plugin · Issue #2457 · jenkins-infra/repository-permissions-updater · GitHub

SecretRetriever is used in redpen-jenkins-integration/RedpenJenkinsListener.java at 585e59e2dc997be93ae12486a0fdfe0e8fcb54e9 · AjmeraInfotech/redpen-jenkins-integration · GitHub which has a Run and gets the credential ID from job properties. That could just use findCredentialById(String id, Class<C> type, Run<?,?> run, List<DomainRequirement> domainRequirements) instead of looping over the results of lookupCredentials and comparing credential IDs. See Track usage of a credential against specific Jenkins context object

However, findCredentialById uses the authorization of the Job rather than ACL.SYSTEM, which you were using. This has two consequences if you start using findCredentialById:

  • You should also change the configuration UI so that it won’t let the user choose a credential that would cause an error later because the job is not authorized to use it.
  • Users have to configure the credentials such that jobs can access them. This will let pipeline jobs use credential binding to read the secrets, so people who can edit such pipelines can find out those secrets. If the credentials are generally defined by Jenkins administrators and have high access to https://api.redpen.ai then maybe it’s a bad idea to force them to be disclosed to owners of pipelines in that way.
2 Likes